From: Stefan Beller <sbeller@google.com>
Date: Tue, 15 Nov 2016 22:20:39 GMT
Subject: Re: [PATCH v3 2/4] serialize collection of refs that contain submodule changes
Message-ID: <CAGZ79kY4aA-vx+qfiACd9NOtao4q02PxZgw-Yq+JMuAz_cqLvw@mail.gmail.com>
In-Reply-To: <616038c9b59cfcccce180de480c2a168921b9a63.1479221071.git.hvoigt@hvoigt.net>

On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:

> +++ b/submodule.c
> @@ -500,6 +500,13 @@ static int has_remote(const char *refname, const struct object_id *oid,
>         return 1;
>  }
>
> +static int append_sha1_to_argv(const unsigned char sha1[20], void *data)
> +{
> +       struct argv_array *argv = (struct argv_array *) data;

nit: no explicit cast needed when coming from a void pointer.