From: Stefan Beller <sbeller@google.com>
Date: Fri, 05 Aug 2016 19:08:46 GMT
Subject: Re: [PATCH 4/6] submodule--helper update-clone: allow multiple references
Message-ID: <CAGZ79kY4YxftihTP_cNqLrVTn0wrfNd5_mb40AB-t2beyzvdLA@mail.gmail.com>
In-Reply-To: <20160804195159.7788-5-sbeller@google.com>

> -               ${reference:+--reference "$reference"} \
> +               ${reference:+"$reference"} \

Note how this changed the API of the submodule--helper.
Currently we pass in --reference $reference
and $reference consists of the string "--reference" and the actual
reference. So it looked like '--reference' '--reference=foo'

That is why we can pass the argument unseen to clone in the helper
via

    argv_array_push(&child->args, suc->reference);

This is fixed now.