From: Stefan Beller Date: Thu, 20 Jul 2017 23:05:11 GMT Subject: Re: [PATCH v3 00/30] Create a reference backend for packed refs Message-ID: In-Reply-To: <20170705091216.ij4uzp3wgsalb56f@sigill.intra.peff.net> On Wed, Jul 5, 2017 at 2:12 AM, Jeff King wrote: > On Sat, Jul 01, 2017 at 08:30:38PM +0200, Michael Haggerty wrote: > >> This is v3 of a patch series creating a `packed_ref_store` reference >> backend. Thanks to Peff and Junio for their comments about v2 [1]. >> >> Changes since v2: >> >> * Delete some debugging `cat` commands in t1408. >> >> * Add some tests of reading packed-refs files with bogus contents. >> >> * When reporting corruption in packed-refs files, distinguish between >> unterminated lines and other corruption. >> >> * Fixed a typo in a commit message. > > Thanks. I just quickly re-reviewed based on the diff from v2, and it > looks good to me. > > -Peff We have a user that reports: The issue is for users who have a mirrored repository, "git pack-refs" now overwrites the .git/packed-refs symlink instead of following it and replacing the file it points to. I suspect this series to be at fault, as the bug report came in a day after we deployed next containing these changes. Do symlinks and packed-refs ring a bell for this series? Thanks, Stefan