From: M Hickford <mirth.hickford@gmail.com>
Date: Mon, 03 Apr 2023 07:00:00 GMT
Subject: Re: [PATCH v2] credential/wincred: store password_expiry_utc
Message-ID: <CAGJzqskDmiYwoe2tdgLbxCpRHzZZMon-SxjLqiJ8OYMk3f0hcg@mail.gmail.com>
In-Reply-To: <xmqqo7oahws8.fsf@gitster.g>

On Thu, 30 Mar 2023 at 20:20, Junio C Hamano <gitster@pobox.com> wrote:
>
> "M Hickford via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: M Hickford <mirth.hickford@gmail.com>
> >
> > This attribute is important when storing OAuth credentials which may
> > expire after as little as one hour. See
> > https://github.com/git/git/commit/d208bfdfef97a1e8fb746763b5057e0ad91e283b
>
> Readers do not have to visit GitHub at all, and proposed log message
> shouldn't force them to.  Refer to an existing commit in this
> project like so instead:
>
>     ... as one hour.  d208bfdf (credential: new attribute
>     password_expiry_utc, 2023-02-18) added support for this
>     attribute in general so that individual credential backend like
>     wincred can use it.
>

Thanks Junio for the example. I'll update the commit message in patch v3.