From: Garrett Cooper <yaneurabeya@gmail.com>
Date: Tue, 02 Apr 2013 19:39:48 GMT
Subject: Re: [PATCH 4/5] branch: mention start_name in set-upstream error messages
Message-ID: <CAGHfRMA8oAX-vigeYXxEVzWsrcPaWw0jCoOHWUMA-gbbAESNRA@mail.gmail.com>
In-Reply-To: <20130402190451.GD32316@sigill.intra.peff.net>

On Tue, Apr 2, 2013 at 12:04 PM, Jeff King <peff@peff.net> wrote:
> If we refuse a branch operation because the tracking
> start_name the user gave us is bogus, we just print
> something like:
>
>  fatal: Cannot setup tracking information; start point is not a branch
>
> If we mention the actual name we tried to use, that may help
> the user figure out why it didn't work (e.g., if they gave
> us the arguments in the wrong order).
>
> Signed-off-by: Jeff King <peff@peff.net>

LGTM!

Reviewed-by: Garrett Cooper <yaneurabeya@gmail.com>