From: Norman Rasmussen Date: Tue, 15 Oct 2019 04:34:55 GMT Subject: Re: [PATCH 1/1] diff-highlight: fix a whitespace nit Message-ID: In-Reply-To: <20191015042006.GC32308@sigill.intra.peff.net> On Mon, Oct 14, 2019 at 9:20 PM Jeff King wrote: > There are a few lines just above that have 8+ spaces. Arguably those > could be tabs, too, depending on your view of tabs. We usually do "8 > spaces is a tab" in the Git project, but the oft-repeated "tabs to > indent, spaces to align" mantra would apply here (and I suspect you're > using a different tabwidth since you noticed this one case). So I'd just > as soon leave them be, and take your patch as-is. Yep, the lines above are using the spaces to align the sections of the multi-line if statement. This happens again for the return statements in highlight_pair and is_pair_interesting. So this is the only line that doesn't stick to the rule (and probably because of editor auto-indenting). I have another change for the same change (which I'll send once I've written tests) and I only noticed this line when I changed my editor's default tabwidth after a while of coding. -- - Norman Rasmussen - Email: norman@rasmussen.co.za - Home page: http://norman.rasmussen.co.za/