From: Jiří Hruška Date: Mon, 27 Nov 2023 13:39:00 GMT Subject: Re: [PATCH v2 0/5] Avoid hang if curl needs eof twice + minor related improvements Message-ID: In-Reply-To: <20231115232824.2507648-1-jonathantanmy@google.com> > I've already reviewed 1/5 so I'll summarize what I think of the rest. Thank you for your time looking at everything, Jonathan. I'm sorry for the delay in my reply, I was away for a while and also trying to get clarity from the cURL side, summarized in [1]. [1] https://lore.kernel.org/git/CAGE_+C5u9H8m5faK1vXKk6QTyjcHgKHqxOZy5ptzsYbF_0yrCQ@mail.gmail.com/ Most importantly, the bug has been apparently in libcurl only for ~1 year and it can no longer manifest for a few months. Therefore, the main point of my changes is a bit moot and we might reconsider what is useful and what is not. > I'm a bit reluctant to include 2/5 and 4/5. > I think 3/5 [...], part of 4/5 [...] and 5/5 have significant benefit and > should be included, though. Fair enough. I will update everything based on your and other's comments and my new learnings, then the final decision can be made about each part.