From: Calvin Wan <calvinwan@google.com>
Date: Tue, 10 Sep 2024 19:26:16 GMT
Subject: Re: [PATCH v3 4/6] config: add git_configset_alloc() and git_configset_clear_and_free()
Message-ID: <CAFySSZDj2wOmzGMvnCFgVLXQK97Q01R4QJRPbMbaTwZ4h3h8kg@mail.gmail.com>
In-Reply-To: <c8d65466-a9c3-4556-84c1-3daf0c7cea14@gmail.com>

On Tue, Sep 10, 2024 at 1:50 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> On 10/09/2024 07:41, Patrick Steinhardt wrote:
> > Is there ever a case where one wants to
> > allocate the configset, but not use it?
>
> That was my thought too - I suggested providing git_configset_new() that
> would allocate and initialize a config set in my response to the last
> round [1]. It is good to see that the struct in now namespaced in the
> next patch but separating out allocation and initialization makes the
> api harder to use than it needs to be. I'd also like to see
> git_configset_clear_and_free() become git_configset_free().
>
> Best Wishes
>
> Phillip
>
> [1]
> https://lore.kernel.org/git/47b18fa4-f01b-4f42-8d04-9e145515ccc1@gmail.com

Agreed, it doesn't make sense to have both alloc() and init() when
they can be combined and same with renaming
git_configset_clear_and_free() to git_configset_free().