From: Calvin Wan <calvinwan@google.com>
Date: Wed, 08 Feb 2023 23:12:20 GMT
Subject: Re: [PATCH v7 5/7] diff-lib: refactor out diff_change logic
Message-ID: <CAFySSZC31aT4zu=-y1vBBd_Z=KWWYn3-7yziLfVbeK9Foc9c3w@mail.gmail.com>
In-Reply-To: <4ae106ed-bfa8-2824-c0c7-6cde32dbe369@dunelm.org.uk>

> I worry that having three integer parameters next to each other makes it
> very easy to mix them up with out getting any errors from the compiler
> because the types are all compatible. Could the last two be combined
> into a flags argument? A similar issues occurs in
> match_stat_with_submodule() in patch 7

I'm not sure how much more I want to engineer a static helper function
that is only being called in one other place. I also don't understand what
you mean by combining the last two into paramters a flags argument.