From: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Date: Thu, 29 Oct 2026 09:03:16 GMT
Subject: Re: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh
Message-ID: <CAFpMFfA17dnuLSRt97BrM0u3cHAifJybr_Zc2ahr_zq2nspgsw@mail.gmail.com>
In-Reply-To: <CAKUOgLz3sefhypa9yzLszW43uQ=Jor_nRBAJaBXXv0d8M2ePBw@mail.gmail.com>

On Thu, Oct 29, 2026 at 9:10 AM Immaculate Mecha
<immaculatemecha87@gmail.com> wrote:
>
> Hi,
>
> I'm preparing a microproject contribution for Outreachy and have been
> exploring a small test cleanup in Git.
>
> In t/t0081-find-pack.sh, line 35 currently uses:
>
> test -f "$head_commit_pack" &&
>
> I'm considering replacing it with Git's test helper:
>
> test_path_is_file "$head_commit_pack" &&
>
> I checked the file's history using git blame and confirmed that this
> is the only test -f, test -e, or test -d check in that script.
>
> Would this be an appropriate and useful microproject, or is there a
> reason to leave this check as it is?


Hi Immaculate,

Welcome! I think Shashank S already changed this exact line in t0081

https://lore.kernel.org/git/pull.2254.v2.git.1792061236183.gitgitgadget@gmail.com/

Before choosing a microproject, it helps to search the list archive
at https://lore.kernel.org/git/ for the file name, and to check the
"What's cooking" reports, to make sure nobody is already working on
it.

Good luck!
Okhuomon