From: Thomas Badie <thomas.badie@gmail.com>
Date: Mon, 25 Jun 2012 10:12:51 GMT
Subject: Re: [PATCH] git-add--interactive.perl: Remove two unused variables
Message-ID: <CAFjFENo7qLTZHrEtPPBLGzp=h0w69C+7C2zfiJJmqFANmaWAgg@mail.gmail.com>
In-Reply-To: <7vfw9khrrt.fsf@alter.siamese.dyndns.org>

2012/6/25 Junio C Hamano <gitster@pobox.com>:
> "Thomas \"Enki\" Badie" <thomas.badie@gmail.com> writes:
>
>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable
>> unused in `diff_applies' and `patch_update_file'.
>>
>> Signed-off-by: Thomas Badie <badie@lrde.epita.fr>
>> ---
>> Hello,
>> This is my first patch. It introduces a really minor change, and I
>> also want to be sure the way I submit it is the right way. Thanks :)
>
> The patch submission is almost perfect, except that:
>
>  (1) the patch seems to be whitespace damaged; and
>

The only damage I see is a space on the deleted lines which doesn't
exist in the patch. Is that you're talking about ?
I need to investigate why it appears...

>  (2) the author of the problematic commit should have been Cc'ed
>     (especially when he is still an active participant on the list)
>     to give him a chance to Ack it (I'm adding Thomas for this).

My bad, I forgot to check if the commiter were still active. I'll check it
for the next time.

> Thanks.  I like that you identified why this is a good thing by
> quoting the problematic change.

Thanks :)

>>  git-add--interactive.perl |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/git-add--interactive.perl b/git-add--interactive.perl
>> index d948aa8..710764a 100755
>> --- a/git-add--interactive.perl
>> +++ b/git-add--interactive.perl
>> @@ -1067,7 +1067,6 @@ EOF
>>  }
>>
>>  sub diff_applies {
>> -      my $fh;
>>        return run_git_apply($patch_mode_flavour{APPLY_CHECK} . '--check',
>>                             map { @{$_->{TEXT}} } @_);
>>  }
>> @@ -1514,7 +1513,6 @@ sub patch_update_file {
>>        }
>>
>>        if (@result) {
>> -              my $fh;
>>                my @patch = reassemble_patch($head->{TEXT}, @result);
>>                my $apply_routine = $patch_mode_flavour{APPLY};
>>                &$apply_routine(@patch);

-- 
Thomas "Enki" Badie