From: David Michael Barr <davidbarr@google.com>
Date: Tue, 05 Jun 2012 07:07:53 GMT
Subject: Re: [RFC 4/4] Add cat-blob report pipe from fast-import to remote-helper.
Message-ID: <CAFfmPPP1koMnYBFbgHt0MGr77okjL5OdAh-TMxFTevj+mDbOZQ@mail.gmail.com>
In-Reply-To: <20120605065628.GA25809@sigill.intra.peff.net>

On Tue, Jun 5, 2012 at 4:56 PM, Jeff King <peff@peff.net> wrote:
> On Mon, Jun 04, 2012 at 07:20:55PM +0200, Florian Achleitner wrote:
>> @@ -427,6 +469,11 @@ static int fetch_with_import(struct transport *transport,
>>       if (get_importer(transport, &fastimport))
>>               die("Couldn't run fast-import");
>>
>> +
>> +     /* in the parent process we close both pipe ends. */
>> +     close(data->fast_import_backchannel_pipe[0]);
>> +     close(data->fast_import_backchannel_pipe[1]);
>
> I'm confused. We close both ends? Who is actually reading and writing to
> this pipe, then?

One child, git-fast-import writes to one end.
The other child, git-remote-* reads from the other end.

--
David Barr