From: Nasser Grainawi Date: Tue, 03 Mar 2026 23:29:13 GMT Subject: Re: [PATCH v5] submodule: fetch missing objects from default remote Message-ID: In-Reply-To: On Tue, Mar 3, 2026 at 2:26 PM Junio C Hamano wrote: > > Ramsay Jones writes: > > > + diff -u expect_fetch_custom actual_fetch_warnings_removed > > --- expect_fetch_custom 2026-03-03 20:35:13.949600802 +0000 > > +++ actual_fetch_warnings_removed 2026-03-03 20:35:14.150601532 +0000 > > @@ -4,9 +4,9 @@ > > Fetching submodule sub1/subdir/deepsubmodule > > Fetching submodule submodule > > Fetching submodule submodule/subdir/deepsubmodule > > -From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1 > > - * branch 43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD > > -Fetching submodule sub1/subdir/deepsubmodule > > From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/submodule > > * branch e38933e027ee8a2000f603124aa899302a09a51f -> FETCH_HEAD > > Fetching submodule submodule/subdir/deepsubmodule > > +From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1 > > + * branch 43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD > > +Fetching submodule sub1/subdir/deepsubmodule > > error: last command exited with $?=1 > > not ok 44 - fetch new submodule commits on-demand outside standard refspec with custom remote name > > > > ... > > > > $ > > > > From which I guess that the order of the output is somewhat unpredictable. > > > > Also, other test files in that patch didn't fail for me with 'make test', but it > > could be possible that they are also flaky. I didn't look. > > Ah, looks like the command tries to fetch from multiple places in > parallel and it is up to the luck which one reports its result > first? We probably do not want such a "human readable progress > output should look exactly like this" test. > > Thanks for reporting. Yes, thank you. I'll drop that part of the test and just keep the GIT_TRACE check.