From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Tue, 14 Jun 2016 05:57:54 GMT
Subject: Re: [PATCH] strbuf: describe the return value of strbuf_read_file()
Message-ID: <CAFZEwPPd_+9nFPCG51nr5s1XMs5SKXG3O3vbAZmxA-BHvZdFPg@mail.gmail.com>
In-Reply-To: <xmqqfusgbv0e.fsf@gitster.mtv.corp.google.com>

Hey Junio,

On Tue, Jun 14, 2016 at 3:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> It is easy to be misguided on the return value of the function
>> strbuf_read_file(). It does follow the pattern of other standard functions
>> for reading files but its better to explicitly specify it.
>
> Good thing to do; I wonder if we want to explicitly say -1 or
> leave it at "negative values are errors", though (my knee-jerk
> reaction being "do not over-specify more than absolute minimum
> to write callers correctly").

Sure I will re-roll with specifying about negative values as errors.

Regards,
Pranit Bauva