From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Sun, 27 Mar 2016 11:59:47 GMT
Subject: Re: [PATCH v10 3/3] commit: add a commit.verbose config variable
Message-ID: <CAFZEwPOhTC_LjUPHMN0PJsc94gvmHgmQL2Xe63oRGOiEMR2jjQ@mail.gmail.com>
In-Reply-To: <1459079497-19121-1-git-send-email-szeder@ira.uka.de>

On Sun, Mar 27, 2016 at 5:21 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
>> +test_expect_success 'commit.verbose true and --no-verbose' '
>> +     git -c commit.verbose=true commit --amend --no-verbose &&
>> +     ! test -s out
>
> Please use the test_must_be_empty helper instead, because it has a
> nice, human-readable name and it complains with a helpful error
> message if something goes wrong, whereas 'test -s' just fails
> silently.

Thanks for pointing it out. I was unsure whether 'test -s' is a good
choice but used it since I did not know any other alternative.