From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Fri, 10 Jun 2016 07:52:35 GMT
Subject: Re: [PATCH 2/2] bisect--helper: `check_expected_revs` shell function in C
Message-ID: <CAFZEwPNYxWpFcspHL8Oo3NydUPuKQeZWCFphM_an+_iKk9wBVw@mail.gmail.com>
In-Reply-To: <CAPig+cQVWng0idk0ETRQA44OsS5+GewVX=pt4uOg-=SFbL+deQ@mail.gmail.com>

Hey Eric,

On Fri, Jun 10, 2016 at 3:24 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Wed, Jun 8, 2016 at 11:24 AM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> Reimplement the `check_expected_revs` shell function in C and add a
>> `--check-expected-revs` subcommand to `git bisect--helper` to call it
>> from git-bisect.sh .
>> [...]
>> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
>> ---
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 06bc9b8..500efd5 100644
>> @@ -174,13 +174,28 @@ static int is_expected_rev(const char *expected_hex)
>> +static int check_expected_revs(const char **revs, int no)
>
> In this codebase, it's more common to name this 'nr' rather than 'no'.
> 'revs_nr' would also be a good name.

Thanks. I will use `revs_nr`.

Regards,
Pranit Bauva