From: Pranit Bauva Date: Mon, 13 Jun 2016 14:24:32 GMT Subject: Re: [PATCH] Document the 'svn propset' command. Message-ID: In-Reply-To: <81a197e2-7e0e-176a-c934-0e5f95cfda83@freebsd.org> Hey Alfred, On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein wrote: > Thank you Pranit. I thought that "signed off by" is used once someone > approved my patch as opposed to when it's in "proposal" stage. This was my > first email with a patch for this issue, who should/could I have used for > "signoff"? Signoff is used to indicate that you are OKAY with releasing your patch according to git's license. For more details see the Documentation/SubmittingPatches[1]. To summarize you will have to add this in the end : Signed-off-by: Alfred Perlstein Though I will still recommend you to go through [1] properly. Regards, Pranit Bauva