From: Pranit Bauva Date: Thu, 24 Mar 2016 10:22:54 GMT Subject: Re: [PATCH v9 3/3] commit: add a commit.verbose config variable Message-ID: In-Reply-To: <1458813876-10591-1-git-send-email-szeder@ira.uka.de> On Thu, Mar 24, 2016 at 3:34 PM, SZEDER Gábor wrote: >> Add commit.verbose configuration variable as a convenience for those >> who always prefer --verbose. >> >> Helped-by: Junio C Hamano >> Helped-by: Eric Sunshine >> Signed-off-by: Pranit Bauva >> >> --- >> The previous version of the patch are: >> - [v8] $gmane/288820 >> - [v7] $gmane/288820 >> - [v6] $gmane/288728 >> - [v5] $gmane/288728 >> - [v4] $gmane/288652 >> - [v3] $gmane/288634 >> - [v2] $gmane/288569 >> - [v1] $gmane/287540 >> >> Changes with respect to the previous patch: >> - Compare with -1 as only -1 value is used for unspecified behavior. >> - Write clean tests >> --- >> Documentation/config.txt | 4 ++++ >> Documentation/git-commit.txt | 3 ++- >> builtin/commit.c | 13 ++++++++++- >> t/t7507-commit-verbose.sh | 51 ++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 69 insertions(+), 2 deletions(-) > > Please always run the full test suite before submitting patches to > make sure that your changes do not inadvertently break something. > This patch breaks several tests in t7512-status-help.sh, > t7508-status.sh and t7060-wtstatus.sh. Sorry for that. I will make sure I do run the complete test suite. I currently ran only commit based tests. But now that I think about it that since status and commit share a lot of things, it might be possible to break parts of status. I will investigate further as to what cased this problem though I kind of get a hint that it is because of verbose being the parent and others consuming it. There are a lot of tests failing.