From: Pranit Bauva <pranit.bauva@gmail.com>
Date: Wed, 13 Apr 2016 09:15:31 GMT
Subject: Re: [PATCH v14 6/6] commit: add a commit.verbose config variable
Message-ID: <CAFZEwPN+N+21CN+P3oegaxEve59BKHabdfyM_c7QdjV+bonpQA@mail.gmail.com>
In-Reply-To: <CAPig+cTcCyGu5Y8aHbE3i6fXh3T_mD0ZiuxPFh=DVHOE38pE5w@mail.gmail.com>

On Wed, Apr 13, 2016 at 11:44 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>
>> +test_expect_success 'status does not verbose without --verbose' '
>> +       git status >actual &&
>> +       ! grep "^diff --git" actual
>> +'
>
> But what is this test checking?

status is also a consumer of the verbose whose initial value is set to
-1. This makes it include verbose in status output. This bug was fixed
by explicitly initializing verbose to 0 if -1. SZEDER pointed out a
bug[1] which broke some tests in and then when I fixed it, you
requested me to include tests even in this patch[2] which I found
convincing enough.

[1]: http://article.gmane.org/gmane.comp.version-control.git/289730
[2]: http://article.gmane.org/gmane.comp.version-control.git/289993