From: Pranit Bauva Date: Thu, 31 Mar 2016 14:24:47 GMT Subject: Re: Signed-off-by vs Reviewed-by Message-ID: In-Reply-To: <20160331123507.GC19857@collabora.co.uk> On Thu, Mar 31, 2016 at 6:05 PM, Miklos Vajna wrote: > Hi, > > Some projects like LibreOffice don't use Signed-off-by, instead usually > use Gerrit for code review, and reviewers add a Reviewed-by line when > they are OK with a patch. In this workflow it's a bit unfortunate that > adding a Signed-off-by line is just a command-line switch, but adding a > Reviewed-by line is more complex. > > Is there anything in git that could help this situation? I didn't see > any related config option; I wonder if a patch would be accepted to make > the "Signed-off-by" line configurable, or there is a better way. Actually there is a "related" config option format.signOff (more about this in Documentation/config.txt) which is a boolean. But that will only enable the "-s" by default. > Like, would a patch that adds e.g. a core.signedOffString configuration > option to make the string customizable welcome? Are you suggesting to use a different email address for commiting, signing off and reviewing? > Thanks, > > Miklos