From: Pranit Bauva Date: Fri, 25 Mar 2016 14:50:49 GMT Subject: Re: [PATCH v9 2/3] t7507-commit-verbose: make test suite use write_script Message-ID: In-Reply-To: <20160325154638.Horde.LzlsD6cZcQfmt894cll_0Tl@webmail.informatik.kit.edu> On Fri, Mar 25, 2016 at 8:16 PM, SZEDER Gábor wrote: > By redirecting grep's output to a file in the editor script, like this > patch wanted to, we can count the lines in the test script itself after > 'git commit' finished. This way we could use test_line_count, with > all its error reporting benefits, and we could use the same editor > script for all tests. > > And if you insist on doing the line counting in the editor script, then > why redirecting grep's output and 'wc -l' separately, why not 'grep -c'? Nice way. Hadn't thought of this before. This will also eliminate having 2 different scripts to test for 1 line and other to test for 2 lines.