From: Pranit Bauva Date: Wed, 13 Apr 2016 09:00:33 GMT Subject: Re: [PATCH v14 5/6] t7507-commit-verbose: improve test coverage by testing number of diffs Message-ID: In-Reply-To: On Wed, Apr 13, 2016 at 11:33 AM, Eric Sunshine wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: >> Make the fake "editor" store output of grep in a file so that we can >> see how many diffs were contained in the message and use them in >> individual tests where ever it is required. A subsequent commit will >> introduce scenarios where it is important to be able to exactly >> determine how many diffs were present. >> >> Also use write_script() to create the fake "editor". >> >> The fake "editor" is always made to succeed regardless of whether grep >> found diff headers or not so that we don't have to use 'test_must_fail' >> for which 'test_line_count = 0' is an easy substitute and also helps in >> maintaining the consistency. > > As mentioned by [1], the change to write_script() is a minor aside; it > is less important than the explanation of how and why the return value > of the fake "editor" changed, thus the order of the 2nd and 3rd > paragraphs should be swapped. > > [1]: http://article.gmane.org/gmane.comp.version-control.git/290663 I will include this if I do a re-roll > >> Helped-by: Eric Sunshine >> Signed-off-by: Pranit Bauva