From: Lars Hjemli <hjemli@gmail.com>
Date: Wed, 23 Jan 2013 18:29:08 GMT
Subject: Re: [PATCH v2] all: new command used for multi-repo operations
Message-ID: <CAFXTnz7r79JYXQBBcpiOPtUzeafuN3fa82F5rGXd-Hr7tSAEOw@mail.gmail.com>
In-Reply-To: <7vwqv3hlu7.fsf@alter.siamese.dyndns.org>

On Wed, Jan 23, 2013 at 6:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> But I still do not think this loop is correct.  In a repository that
>> has a working tree, you would learn that directory $D has $D/.git in
>> it, feed $D to handle_repo(), and then descend into $D/.git/objects/,
>> $D/.git/refs, and other random directories to see if you can find
>> other repositories....
>
> Ahh, no, you don't.
>
> I still think calling is_git_directory() on $D + "/.git" would be a
> better implementation, though.

Except for the .gitfile case, which is_git_directory() doesn't seem to
handle. I guess I can invoke read_gitfile() when i see that .git is a
file.

-- 
larsh