From: Han-Wen Nienhuys Date: Wed, 08 Dec 2021 14:48:08 GMT Subject: Re: [PATCH 10/10] reftable: make reftable_record a tagged union Message-ID: In-Reply-To: <072ff09c-9174-e769-7ebb-4bb248199337@gmail.com> On Wed, Dec 8, 2021 at 3:35 PM Derrick Stolee wrote: > This is a HUGE diff, especially compared to the previous changes > in this series. I recommend splitting this out into its own series > and finding a way to break it down into smaller changes. Would you have a suggestion how? The reftable_record type is used across the reftable library, so if we change its definition, that impacts most callsites. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado