From: Han-Wen Nienhuys Date: Fri, 23 Apr 2021 08:34:59 GMT Subject: Re: [PATCH] refs: print errno for read_raw_ref if GIT_TRACE_REFS is set Message-ID: In-Reply-To: On Tue, Apr 13, 2021 at 10:08 PM Junio C Hamano wrote: > > Han-Wen Nienhuys writes: > > >> I do wonder if we want strerror(errno) instead of the number, but I > >> can go either way (it's just a trace output). > > > > For tracing, it would be most useful if we got the actual symbol (eg. > > ENOENT). Is there a way to get at that? > > I do not think there is. > > And that is the reason why we see everywhere calls to die_errno(), > error(..., strerror(errno)), etc. > > As this is interpolated into trace with untranslated string, > I suspect that strerror() is not a good match, so let's live with %d > for now. Great! This topic is marked as Waiting for reviews to conclude. cf. but I don't know what is left to do. Oversight? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado