From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 24 Jan 2022 14:14:37 GMT
Subject: Re: [PATCH v6 01/15] reftable: fix OOB stack write in print functions
Message-ID: <CAFQ2z_Pe6PsV4nMRqQRrFTnOQ2+Lb1o-pCn2oBiVAkec2RtkPw@mail.gmail.com>
In-Reply-To: <220121.86a6fpl3hr.gmgdl@evledraar.gmail.com>

On Fri, Jan 21, 2022 at 12:42 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> > -     char hex[2 * GIT_SHA256_RAWSZ + 1] = { 0 }; /* BUG */
> > +     char hex[GIT_MAX_HEXSZ + 1] = { 0 }; /* BUG */
>
> Is whatever "BUG" this is still current after this change?

I can't remember what this was about. Dropping.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado