From: Han-Wen Nienhuys <hanwen@google.com>
Date: Thu, 10 Jun 2021 11:58:48 GMT
Subject: Re: [PATCH 7/8] refs: stop setting EINVAL and ELOOP in symref resolution
Message-ID: <CAFQ2z_OfRGG5kF2OhYrm5OLMOOmz-dHd+-ocWwC_7Tt+yBYmkg@mail.gmail.com>
In-Reply-To: <20210603025553.349758-1-jonathantanmy@google.com>

On Thu, Jun 3, 2021 at 4:55 AM Jonathan Tan <jonathantanmy@google.com> wrote:
> I don't think this is related to avoiding errno and conveying error
> information through an out param. But besides that, as it is, I'm not
> sure that this is correct. Even if EINVAL is not checked by the caller,
> setting errno to EINVAL here means avoiding exposing a potential
> EISDIR/ENOTDIR that a preceding call set. Same comment for the other
> instances.

You are right, but it's probably moot, because the follow-up commit
stops using errno (making it impossible for EISDIR/ENOTDIR to
haphazardly appear), but I dropped this commit from the series.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado