From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 31 May 2021 14:27:21 GMT
Subject: Re: [PATCH v2 19/21] t7003: check reflog existence only for REFFILES
Message-ID: <CAFQ2z_OC_mOZO5+V4qtg66FrsDy5PyyRXdECztuW8owpZ9WD-w@mail.gmail.com>
In-Reply-To: <87h7ixpg2l.fsf@evledraar.gmail.com>

On Thu, May 20, 2021 at 5:42 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> > -     test_must_fail git reflog exists refs/heads/prune-entire
> > +     if test_have_prereq REFFILES
> > +     then
> > +             test_must_fail git reflog exists refs/heads/prune-entire
> > +     fi
> >  '
> >
> >  test_expect_success '--remap-to-ancestor with filename filters' '
>
> Ditto chicken and egg, but isn't this conflating "we always write logs"
> v.s. reftable just behaving differently, i.e. shouldn't this be
> positively asserting that we have the log *for that branch* still after
> its deletion?

That is a great topic to discuss on the reftable series.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado