From: Han-Wen Nienhuys Date: Tue, 27 Apr 2021 09:22:07 GMT Subject: Re: [PATCH 07/18] t5000: inspect HEAD using git-rev-parse Message-ID: In-Reply-To: <87y2dc4164.fsf@evledraar.gmail.com> On Wed, Apr 21, 2021 at 8:11 AM Ævar Arnfjörð Bjarmason wrote: > If we're doing a "re-style while we're at it" s/// let's > just go all the way and convert it to a more modern style of: > > test_expect_success 'git get-tar-commit-id' ' > But maybe such re-styling would be best left alone, and just a narrow > change of the needed code. There's various surrounding tests in the file > that use the same style, unless we're going to re-style all of them.... The file wasn't style-consistent to begin with, but I've added a commit that restyles the rest of the file. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado