From: Han-Wen Nienhuys <hanwen@google.com>
Date: Tue, 13 Jul 2021 08:02:29 GMT
Subject: Re: [PATCH v5 4/6] refs: add failure_errno to refs_read_raw_ref() signature
Message-ID: <CAFQ2z_NzykfcBSvtHQ10RZWxLP48+qArZk9HbDJQB4tNX-GtYA@mail.gmail.com>
In-Reply-To: <87fswl3vsn.fsf@evledraar.gmail.com>

On Sun, Jul 11, 2021 at 2:00 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
>
> On Wed, Jul 07 2021, Han-Wen Nienhuys via GitGitGadget wrote:
>
> > From: Han-Wen Nienhuys <hanwen@google.com>
> >
> > This lets us use the explicit errno output parameter in refs_resolve_ref_unsafe.
> > [...]
> > +const char *refs_resolve_ref_unsafe_with_errno(struct ref_store *refs,
>
> This and the subsequent commit don't compile for me, because this lacks
> a prototype that you finally add in 6/6.

Whoops! thanks for correcting.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado