From: Han-Wen Nienhuys Date: Tue, 11 Feb 2020 14:20:16 GMT Subject: Re: [PATCH v4 4/5] Add reftable library Message-ID: In-Reply-To: <20200211000520.GA6454@camp.crustytoothpaste.net> On Tue, Feb 11, 2020 at 1:05 AM brian m. carlson wrote: > > As this is within the library, the hash size should be injected > > somewhere. I don't see huge problems here (the hash size could be part > > of the 'struct write_options'), but until we have properly defined how > > reftable will mark the on-disk files as SHA-256, it will only supports > > SHA1. I intend to work set the file format in motion, once this SHA1 > > version is accepted into git-core. > > It's not required to mark the on-disk files. A repository's storage is > either entirely SHA-1 or entirely SHA-256, except for the translation > tables. The entire marking of the repository is in the config file, and > everything in the .git directory is assumed to be in that format. I disagree. I think it should be possible to determine if a file in reftable format is well-formed or not. Since parsing requires knowing the hash size, we have to encode it somewhere. I've uploaded https://git.eclipse.org/r/c/157501/ that proposes a way to encode the hash size. I look forward to feedback. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado