From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 31 May 2021 14:08:49 GMT
Subject: Re: [PATCH v2 18/21] t7900: mark pack-refs tests as REFFILES
Message-ID: <CAFQ2z_N05LyFkpURwyEe1b-ju09zEzZL=kx-kfbPCgqEDL2tkg@mail.gmail.com>
In-Reply-To: <87k0ntpg48.fsf@evledraar.gmail.com>

On Thu, May 20, 2021 at 5:41 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> > -test_expect_success 'pack-refs task' '
> > +test_expect_success REFFILES 'pack-refs task' '
> >       for n in $(test_seq 1 5)
> >       do
> >               git branch -f to-pack/$n HEAD || return 1
>
> I don't think it's superfluous to test what "git maintenance" does
> anyway, i.e. the test ends with:
>
>     test_subcommand git pack-refs --all --prune
>
> Shouldn't we test that we .. don't run that, abort, warn, whatever?

Sure. I've removed the check on the side effect for pack-refs instead.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado