From: Han-Wen Nienhuys Date: Thu, 10 Jun 2021 10:05:21 GMT Subject: Re: [PATCH 3/8] refs: make errno output explicit for read_raw_ref_fn Message-ID: In-Reply-To: <20210603023709.345324-1-jonathantanmy@google.com> On Thu, Jun 3, 2021 at 4:37 AM Jonathan Tan wrote: > Should we initialize "failure" to 0 here? As a reader, I would assume > that "failure" has the semantics of errno here, which upon success, may > or may not be set. Done. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado