From: Han-Wen Nienhuys <hanwen@google.com>
Date: Wed, 07 Jul 2021 08:20:00 GMT
Subject: Re: [PATCH v4 5/6] refs: explicitly return failure_errno from parse_loose_ref_contents
Message-ID: <CAFQ2z_N+uMCG9ewv-P0GgZQ90m5i6Hk_HYEsRb_WuBvPMZKFFA@mail.gmail.com>
In-Reply-To: <xmqqfswrjksb.fsf@gitster.g>

On Tue, Jul 6, 2021 at 9:37 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Han-Wen Nienhuys <hanwen@google.com>
> >
> > The EINVAL error from parse_loose_ref_contents is used in files-backend
> > to create a custom error message.
> >
> > Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> > Reviewed-By: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>
> I think a -By in the trailer is spelled with lowercase, i.e. "Reviewed-by".

.. All done.

I also addressed your other fixup.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado