From: Han-Wen Nienhuys <hanwen@google.com>
Date: Tue, 27 Apr 2021 09:15:16 GMT
Subject: Re: [PATCH 05/18] t1413: use tar to save and restore entire .git directory
Message-ID: <CAFQ2z_MugeKxFbbLAoV1Ax3sQZRpkesvUk4zUYwivbcrE2od6g@mail.gmail.com>
In-Reply-To: <xmqqfszk36z8.fsf@gitster.g>

On Wed, Apr 21, 2021 at 12:51 AM Junio C Hamano <gitster@pobox.com> wrote:

> > +     rm -rf .git && tar -xf .git-saved.tar
>
> Unlike GNUism longer option names like "tar --extract", you do not
> need a single dash when you ask "tar xf" (see our Makefile).
>
> Looking at t/t5000-tar-tree.sh, we seem to be supposed to use "$TAR"
> (with double quotes) to name the tar utility, so that people can say
> TAR=gtar on certain platforms.  I suspect that there already are a
> few existing violations but let's not make it worse.

Done.



-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado