From: Han-Wen Nienhuys <hanwen@google.com>
Date: Mon, 05 Jul 2021 12:24:50 GMT
Subject: Re: [PATCH v2 6/8] serve.c: add trace2 regions for advertise & command
Message-ID: <CAFQ2z_McVjV+DVMZJq21tBsxj2T3EZ5eFJuRWs8ozpNbJWzS1g@mail.gmail.com>
In-Reply-To: <patch-6.8-baeee6539ad-20210628T191634Z-avarab@gmail.com>

On Mon, Jun 28, 2021 at 9:19 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> Now that we've factored out "call_{advertise,command}()" in a
> preceding commit it becomes easy to trace all these callbacks with
> trace2. Let's do that. As the tests demonstrate there's no v2 push
> protocol, which the tests assert.

code looks good, but confused about the objective. This isn't
necessary for the rest of the series, is it?

cleanup changes leading up to here LGTM.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado