From: Vicent Martí <tanoku@gmail.com>
Date: Tue, 05 Aug 2014 18:38:21 GMT
Subject: Re: [PATCH] pack-bitmap: do not use gcc packed attribute
Message-ID: <CAFFjANRwnd4u1Axs64xZNvc1kHynjswX_t4pS3EjBsTsZP0Y7w@mail.gmail.com>
In-Reply-To: <53DFDCD2.2090803@gmail.com>

On Mon, Aug 4, 2014 at 9:19 PM, Karsten Blees <karsten.blees@gmail.com> wrote:
> This raises the question why we read via mmap at all

The first version of the pack bitmap format I wrote for GitHub was 50%
faster to load than this one because it was designed to be mmapable.
Eventually we moved to the JGit-compatible bitmap format (because I
get paid a lot of money to do as I'm told -- not because of some
inherent benefit of the JGit format), which needs to be read
sequentially, but I never bothered to change the mmap reading code.

I believe your patch makes a lot of sense -- at this point we could as
well remove the mmaping altogether and read the file sequentially.

Cheers,
vmg