From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Sun, 01 Nov 2015 08:16:40 GMT
Subject: Re: [PATCH] stash: complain about unknown flags
Message-ID: <CAEwRq=p5AGE4ingzp8QFyUPetkiY7bgCyx6ZeaetzO5uQayXpg@mail.gmail.com>
In-Reply-To: <20150520180132.GB14561@peff.net>

Hello,

On Wed, May 20, 2015 at 8:01 PM, Jeff King <peff@peff.net> wrote:
> The option parser for git-stash stuffs unknown flags into
> the $FLAGS variable, where they can be accessed by the
> individual commands. However, most commands do not even look
> at these extra flags, leading to unexpected results like
> this:
>
>   $ git stash drop --help
>   Dropped refs/stash@{0} (e6cf6d80faf92bb7828f7b60c47fc61c03bd30a1)
>
> We should notice the extra flags and bail. Rather than
> annotate each command to reject a non-empty $FLAGS variable,
> we can notice that "stash show" is the only command that
> actually _wants_ arbitrary flags. So we switch the default
> mode to reject unknown flags, and let stash_show() opt into
> the feature.

Better late than never, that does look good...

-- 
Vincent Legoll