From: Chris Rorvick <chris@rorvick.com>
Date: Wed, 16 Jan 2013 01:53:37 GMT
Subject: Re: [PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport
Message-ID: <CAEUsAPZakGKUmQWrsTaF1cpbQm0Y4C3sDxCWD_i1gkQxeC-bRQ@mail.gmail.com>
In-Reply-To: <1358291405-10173-4-git-send-email-bdwalton@gmail.com>

On Tue, Jan 15, 2013 at 5:10 PM, Ben Walton <bdwalton@gmail.com> wrote:
> Neither %s or %z are portable strftime format specifiers.  There is no
> need for %s in git-cvsimport as the supplied time is already in
> seconds since the epoch.  For %z, use the function get_tz_offset
> provided by Git.pm instead.

Out of curiosity, which platforms are affected?  Assuming DST is a 1
hour shift (patch 2/3) is not necessarily portable either, though this
currently appears to only affect a small island off of the coast of
Australia.  :-)

Chris