From: Daniel Ferreira (theiostream) <bnmvco@gmail.com>
Date: Thu, 30 Mar 2017 18:26:33 GMT
Subject: Re: [PATCH v5 4/6] dir_iterator: add tests for dir_iterator API
Message-ID: <CAEA2_R+w+Pty41RykqBt0XKeNi-4eowNSc=Yh9RL=Lq+Xo=mJg@mail.gmail.com>
In-Reply-To: <a738d683-0f2d-61b9-5ecf-ef8bc8f98ff6@alum.mit.edu>

On Thu, Mar 30, 2017 at 5:05 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> Oh I forgot to mention, in the Git project we don't allow declarations
> to be mixed with code. Apparently there's some ancient compiler
> somewhere that doesn't allow it. Declarations always have to be
> together, at the top of a block. (Compile with
> `-Werror=declaration-after-statement` to detect this.)

Sorry about that. I'm compiling git on clang and it has a bug that
ignores this warning (it shows up on gcc). I'll watch out for it.