From: Ayush Chandekar <ayu.chandekar@gmail.com>
Date: Fri, 11 Jul 2025 19:35:26 GMT
Subject: Re: [GSOC PATCH v5 3/3] environment: remove the global variable 'sparse_expect_files_outside_of_patterns'
Message-ID: <CAE7as+Z5ihQThZ5cXax44XNHoRzqdnZpRTrDdKKGz86cM_BgYw@mail.gmail.com>
In-Reply-To: <xmqqecuzeynr.fsf@gitster.g>

On Wed, Jul 2, 2025 at 2:51 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Ayush Chandekar <ayu.chandekar@gmail.com> writes:
>
> > Yes, I get your point. However, if we look at settings which are
> > shifted to `struct repo_settings`, the behaviour is to set a
> > fallback/default value in case of an invalid input, instead of
> > throwing an error.
>
> So the user will not be told about misconfiguration like they used
> to?  Is that an acceptable way forward, I have to wonder...
>

I was actually mistaken that `prepare_repo_settings()` does not throw
any error due to the fact that it sets default value when a config
setting is not set. So I thought, if there's invalid value in the
config, it would just set the default value, but I was wrong.

Thanks,
Ayush