From: Luke Diamand <luke@diamand.org>
Date: Wed, 02 Sep 2015 21:32:10 GMT
Subject: Re: [PATCH v5] git-p4: add config git-p4.pathEncoding
Message-ID: <CAE5ih7_Kje_Qrz7zKH4uSGziVpdp6VqsZf7hSMwQkvta97CG9w@mail.gmail.com>
In-Reply-To: <1441226355-61103-2-git-send-email-larsxschneider@gmail.com>

On 2 September 2015 at 21:39,  <larsxschneider@gmail.com> wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> Perforce keeps the encoding of a path as given by the originating OS.
> Git expects paths encoded as UTF-8. Add a config to tell git-p4 what
> encoding Perforce had used for the paths. This encoding is used to
> transcode the paths to UTF-8. As an example, Perforce on Windows often
> uses “cp1252” to encode path names.

Looks good to me, and the test passes.

Note that git diff --check complains about a trailing whitespace.