From: Luke Diamand <luke@diamand.org>
Date: Tue, 26 Apr 2016 20:03:55 GMT
Subject: Re: [PATCHv2 2/3] git-p4 tests: work with python3 as well as python2
Message-ID: <CAE5ih79Ot8QBDcRatxxxoQdGKFXNtoQ-=j4uWqQ2g=KjLBNiHQ@mail.gmail.com>
In-Reply-To: <xmqqpotcgt2l.fsf@gitster.mtv.corp.google.com>

On 26 April 2016 at 18:48, Junio C Hamano <gitster@pobox.com> wrote:
> Luke Diamand <luke@diamand.org> writes:
>
>> Update the git-p4 tests so that they work with both
>> Python2 and Python3.
>>
>> We have to be explicit about the difference between
>> Unicode text strings (Python3 default) and raw binary
>> strings which will be exchanged with Perforce.
>>
>> Additionally, print always takes braces in Python3.
>
> s/braces/parentheses/, I think (can locally tweak if you say so--in
> which case no need to resend).

Please do so, thanks!

Luke