From: SASAKI Suguru <sss.sonik@gmail.com>
Date: Mon, 18 Jul 2011 14:26:45 GMT
Subject: SP in committer line in fast-import stream
Message-ID: <CAE3X6mwJquoHj06FVGTsg0qtzyTwbd6gNqy7J4yWiVF-+p-23Q@mail.gmail.com>

Hi,


I'm working with data from `bzr fast-export` and `git fast-import`.
(bzr is 2.4b5, git is 1.7.5.4, on Debian GNU/Linux (sid))

Export and import themselves are OK,
but `git fsck --strict` exits with error, saying:

  error in commit 2e7a16fbe57b555c1c5954470ef66f3a2a089288: invalid
author/committer line - missing space before email

and pushing to remote like GitHub fails.


I found minimal OK-data unlike `bzr fast-export` outputs and NG-data
like `bzr fast-export`.
(Attached: test_NG.data.txt and test_OK.data.txt)

Only one difference between these is a space in committer line.
  * OK: 'committer' SP SP LT GT ...
  * NG: 'committer' SP    LT GT ...

`man git-fast-import` says:

  commit
    Create or update a branch with a new commit, recording one logical
change to the project.

      'commit' SP <ref> LF
      mark?
      ('author' (SP <name>)? SP LT <email> GT SP <when> LF)?
      'committer' (SP <name>)? SP LT <email> GT SP <when> LF
      data
      ('from' SP <committish> LF)?
      ('merge' SP <committish> LF)?
      (filemodify | filedelete | filecopy | filerename | filedeleteall
| notemodify)*
      LF?

I think, from this notations, both data is OK.
What's the problem?

Regards,

-- 
SASAKI Suguru
  mailto:sss.sonik@gmail.com


commit refs/heads/master
mark :1
committer  <> 1162316103 +0000
data 4
test
M 644 inline README
data 11
This is OK.



commit refs/heads/master
mark :1
committer <> 1162316103 +0000
data 4
test
M 644 inline README
data 11
This is NG.