From: Vivan Garg <v.garg.work@gmail.com>
Date: Tue, 21 Feb 2023 22:34:34 GMT
Subject: Re: [GSOC][PATCH v2 1/1] t4121: modernize test style
Message-ID: <CADupsJMGgOzrd7L+Et=5t0a9vXNpZqhT4qzFi_7YbHwMMR6KWg@mail.gmail.com>
In-Reply-To: <77734da5-e711-f653-b022-ba3b26823701@github.com>

On Tue, Feb 21, 2023 at 3:17 PM Victoria Dye <vdye@github.com> wrote:

> The new commit message is sufficiently descriptive, thanks for updating. In
> terms of readability, it is a bit of a run-on sentence (the comma after
> "lines" could be a period, i.e. "...separate lines. Therefore, update
> the..."). I don't think it needs to be updated, but it's something to keep
> in mind for future contributions. :)

I've taken note of it. Thanks!

> Whitespace looks good here. I think this is ready-to-merge; thanks!

Thanks again for the review!