From: Samuel Abraham <abrahamadekunle50@gmail.com>
Date: Sun, 11 Jan 2026 11:04:12 GMT
Subject: Re: [GSoC PATCH v7] add -p: show user's hunk decision when selecting hunks
Message-ID: <CADYq+faxjsY4cpz9JpyV4G2ufxjdkoHBrmkAhs6uFrp79_Fc3A@mail.gmail.com>
In-Reply-To: <xmqqpl7grebf.fsf@gitster.g>

On Sun, Jan 11, 2026 at 4:57 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> writes:
>
> > When a user is interactively deciding which hunks to use or skip for
> > staging, unstaging, stashing etc, there is no way to know the
> > decision previously chosen for a hunk when navigating through the
> > previous and next hunks using K/J respectively.
> >
> > Improve the UI to explicitly show if a user has previously decided to
> > use a hunk (by pressing 'y') or skip the hunk (by pressing 'n').
> > This will improve clarity when and aid the navigation process for the
> > user.
> >
> > Reported-by: Junio C Hamano <gitster@pobox.com>
> > Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
> > ---
> > Changes in v7:
> > ==============
> > - changed hunk selection state message to reduce prompt width
> > - Removed redundant `file_diff->hunk_nr` in hunk->use check
> > - Made the prompt mode more readable by retaining the space before choices
> > - set `hunk_use_decision` to empty string if `hunk->use == UNDECIDED` to match
> >   the prompt mode.
>
> The latest "was: X" does look short and sweet.
>
> Let's wait for a few days to see if others have more input and then
> mark the topic for 'next'.
>
> Thanks.

This sounds good.
Thanks

Abraham.