From: Samuel Abraham Date: Sat, 19 Oct 2024 11:19:17 GMT Subject: Re: [PATCH] notes: teach the -e option to edit messages in editor Message-ID: In-Reply-To: <5e41f019-f37f-4860-b672-78b85e24d9bf@app.fastmail.com> On Sat, Oct 19, 2024 at 11:28 AM Kristoffer Haugsbakk wrote: > > Hi Samuel > > On Sat, Oct 19, 2024, at 02:14, Samuel Adekunle Abraham via GitGitGadget wrote: > > From: Abraham Samuel Adekunle > > > > Notes can be added to a commit using the -m (message), > > -C (copy a note from a blob object) or > > -F (read the note from a file) options. > > When these options are used, Git does not open an editor, > > it simply takes the content provided via these options and > > attaches it to the commit as a note. > > Thanks for this work. I think part of the motivation here is to make > git-notes(1) act more in line with the conventions from git-commit(1), > which is always nice to see. > > It’s also useful in its own right. > > > Improve flexibility to fine-tune the note before finalizing it > > by allowing the messages to be prefilled in the editor and editted > > after the messages have been provided through -[mF]. > > Here you explain how the end-user will benefit from this change. Nice. > > It’s important to explain the background, what is being done, and why it > is being done. And this commit message does all of that. Hello Kristoffer, Thank you very much for your response.