From: Daniel Jacques <dnj@google.com>
Date: Mon, 26 Mar 2018 14:55:04 GMT
Subject: Re: [PATCH v7 0/3] RUNTIME_PREFIX relocatable Git
Message-ID: <CAD1RUU9xFBhmo2-2P6TN_oiYR-fFZ+O6UeJsaXQBZG+dE0h3bQ@mail.gmail.com>
In-Reply-To: <87zi2vvsir.fsf@evledraar.gmail.com>

On Mon, Mar 26, 2018 at 10:08 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com>
wrote:

> > Oh sorry, I must have missed that. I have a personal preference for
adding
> > brackets for clarity; it leaked into this patch set. I did implement
most
> > of the suggestion, which was to use the escaped Q/E instead of equals.
> >
> > Stylistically I still prefer the braces, but I'll defer to you and
remove
> > them in my pending patch set in case I'm asked to submit another
version.

> If you prefer it that way just keep your version. It's your code and
> it's just a trivial style difference.

> I just mentioned it because in the previous discussion you said "I agree
> it's cleaner" so I inferred that you'd just forgotten about it but meant
> to change it. It's also fine if later you just thought "you know what,
> I'm doing it my way" :)

Honestly there's enough of a delay here that I don't remember, but if I had
to guess I probably just forgot to make the change :)