From: Dave Borowitz <dborowitz@google.com>
Date: Fri, 14 Aug 2015 20:29:16 GMT
Subject: Re: [PATCH 0/7] Flags and config to sign pushes by default
Message-ID: <CAD0k6qRAG96a=zhTpw7nta6QjK7gEYTfYvMvCeob35LLzKkKYw@mail.gmail.com>
In-Reply-To: <xmqqbne9ivry.fsf@gitster.dls.corp.google.com>

On Fri, Aug 14, 2015 at 2:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
> So I am fine as long as "if-possible" turns a failure to make signed
> push into a success _only_ when the reason of the failure is because
> we did not see the capability supported by the receiving end.  If
> the reason why you cannot do a signed push is because you cannot
> sign push certificate, "if-possible" should still fail.

I completely agree with your reasoning, and that's exactly how I
implemented and documented --signed-if-possible.

>From patch 6/7:
+--signed-if-possible::
+       Like --signed, but only if the server supports signed pushes. If
+       the server supports signed pushes but the `gpg` is not available,
+       the push will fail.