From: Bello Olamide Date: Thu, 15 Jan 2026 22:17:17 GMT Subject: Re: [Outreachy PATCH v2 0/3] store git_default_config() parsed values in new config struct Message-ID: In-Reply-To: On Tue, 13 Jan 2026 at 18:25, Olamide Caleb Bello wrote: > > Hi Git Community, > Over the course of my ongoing internship, which focused on moving global > variables in environment.h into local scope, I have attempted to move some > variables into the struct repo-settings. > However there have been some design concerns as regards the use of > `prepare_repo_settings()` with respect to when and where to call the > function, and also the change in behaviours when the variable is lazily > loaded as discussed in [1] and [2]. > > After different deliberations, Phillip Wood proposed creating a new config > struct [3], adding it to the repository struct and passing the repo struct to > `git_default_config()` to store the parsed config values per repo. > This ensures the current behaviours will be retained. > > I have experimented with this approach for some values and I would > appreciate feedbacks about this approach before we can move forward > and use it for more variables related to `git_default_config()`. > > For now, the parsed value is stored in `the_repository` in > `git_default_*_config()` and further efforts to pass the repository > parameter to `git_default_config()` as the callback parameter will > be looked into later on. > The link to the CI tests can be see in [4] > > 1. https://lore.kernel.org/git/43aaec10-2696-44c9-8728-2045b83dc5d3@gmail.com/ > 2. https://lore.kernel.org/git/a881499d-e236-4f8e-a217-b6bce69e3e3c@gmail.com/ > 3. https://lore.kernel.org/git/8899016f-eeef-404b-8da6-ff3a90e81cea@gmail.com/ > 4. https://github.com/git/git/actions/runs/20953059862 > > Changes in v2: > ============== > - Renamed new struct to repo_config_values > - Moved struct and functions declaration and definition to > environment.[ch] > - embedded the new struct in the repository struct thereby removing the > need to allocate memory on the heap > Hello, I would like to know if there are new comments. I want to send a new patch version. Thanks